What makes you close all PRs?

Started by MarshMello, February 10, 2024, 05:19:35 PM

Previous topic - Next topic
Print
Go Down Pages1
User actions

MarshMello

February 10, 2024, 05:19:35 PM
This is more of a question directed to Phill but can be answered by anyone.

I was looking at the Exif Tool GitHub, after wondering if I can submit a PR to fix the issue I had a while ago. Saw that all PRs get closed, not merged but then you commit the code from a different name "exiftool".

I'm curious, why this approach?

Phil Harvey

#1
February 10, 2024, 05:30:30 PM
I merge all PR's by hand, and usually I make adjustments when I do this.

I'm not really familiar with best practices on github, but I have an "exiftool" user that owns the ExifTool code and does all of the updates via the command line, but I usually use my personal account when accessing via the web interface.

If you are an experienced github user and this seems odd to you, then it is probably because I'm not.  :P

- Phil
...where DIR is the name of a directory/folder containing the images.  On Mac/Linux/PowerShell, use single quotes (') instead of double quotes (") around arguments containing a dollar sign ($).

MarshMello

#2
February 10, 2024, 05:51:04 PM
Quote from: Phil Harvey on February 10, 2024, 05:30:30 PM...
- Phil

Makes sense,  thanks for the super quick response!
Print
Go Up Pages1
User actions