ExifTool Forum

ExifTool => Bug Reports / Feature Requests => Topic started by: dae65 on July 22, 2020, 05:49:38 PM

Title: patch submission to add QuickTime tags
Post by: dae65 on July 22, 2020, 05:49:38 PM
Dear Phil,

Would you accept a patch (attached) to add support to some QuickTime tags to Image::ExifTool, please? These tags are supported by AtomicParsley (https://github.com/wez/atomicparsley).

These are new:

Group     ID    Name               Atom
ItemList  ©st3  Subtitle           moov.udta.meta.ilst.©st3.data
ItemList  ©con  Conductor          moov.udta.meta.ilst.©con.data
ItemList  ©sol  Soloist            moov.udta.meta.ilst.©sol.data
ItemList  ©ope  OriginalArtist     moov.udta.meta.ilst.©ope.data
ItemList  ©ard  ArtDirector        moov.udta.meta.ilst.©ard.data
ItemList  ©sne  SoundEngineer      moov.udta.meta.ilst.©sne.data
ItemList  ©xpd  ExecutiveProducer  moov.udta.meta.ilst.©xpd.data
ItemList  sdes  StoreDescription   moov.udta.meta.ilst.sdes.data


The following are already supported by Image::ExifTool. However, AtomicParsley writes them as ItemList tags, whereas Image::ExifTool currently writes them as UserData tags only.

Group     ID    Name               Atom
ItemList  ©arg  Arranger  moov.udta.meta.ilst.©arg.data
ItemList  ©dir  Director  moov.udta.meta.ilst.©dir.data
ItemList  ©prd  Producer  moov.udta.meta.ilst.©prd.data


Please find a diff file attached. I've applied it against version 12.01, and successfully built a deb package using dh-make-perl.

Thanks.
Title: Re: patch submission to add QuickTime tags
Post by: Phil Harvey on July 22, 2020, 09:31:55 PM
Thanks.  I'll take a look at this when I get a chance and include it in the next release if everything is OK.

- Phil
Title: Re: patch submission to add QuickTime tags
Post by: dae65 on July 25, 2020, 09:31:58 AM
Phil, do you think you'll be able to include these in the next release? Having read a lot of documentation, code, and forum threads in the past few days, I can say ExifTool is about to become, not only the best and most comprehensive, but also the only complete MP4 tag writer there is.
Title: Re: patch submission to add QuickTime tags
Post by: Phil Harvey on July 27, 2020, 07:11:05 AM
Yes, these will be in the next release
Title: Re: patch submission to add QuickTime tags
Post by: dae65 on July 27, 2020, 10:15:21 AM
Thanks a lot!
Title: Re: patch submission to add QuickTime tags
Post by: dae65 on August 01, 2020, 07:03:54 AM
Dear Phil,

I noticed those new QuickTime tags were added to the Keys, instead of ItemList group. I was wondering why. Would you move them to the ItemList group, please? The previously existing IDs in the Keys table don't even look like ©con, ©st3, etc.

Thank you.
Title: Re: patch submission to add QuickTime tags
Post by: Phil Harvey on August 03, 2020, 09:39:53 PM
Ooops.  Sorry.  I'll fix this.  Cut-n-paste error. :(

- Phil