ExifTool Forum

ExifTool => Developers => Topic started by: obetz on July 09, 2019, 01:03:43 PM

Title: Test coverage
Post by: obetz on July 09, 2019, 01:03:43 PM
Hi Phil,

to make sure that I include all necessary stuff, I checked which files are accessed during the built-in selftests.

I found several "unused" files, but I can't decide whether more tests should be added.

Here my list, I tried to put the most interesting candidates first (maybe unimportant after Math/*):

Win32\FindFile.pm and dll
Digest\Perl\MD5.pm
Time\Piece.pm and dll
Time\Seconds.pm
File\stat.pm
MIME\Base64.pm (and dll)
Bzip2
Math\BigFloat\ and Math\BigInt via Win32API::File, PAR didn't see that use64bitint is defined?
autouse.pm
bytes_heavy.pl
Class\Struct.pm
feature.pm
IO\Dir.pm
IO\Pipe.pm
IO\Select.pm
IO\Socket.pm
IO\Socket\INET.pm
IO\Socket\UNIX.pm
IO\Uncompress\Adapter
locale.pm
mro.pm and dll
overload\numbers.pm
re.pm and dll
Socket.pm and dll
Term\Cap.pm
Title: Re: Test coverage
Post by: Phil Harvey on July 09, 2019, 03:46:12 PM
Some modules are optional, and used if they are available:

% exiftool -ver -v
ExifTool version 11.55
Perl version 5.018004 (-C0)
Platform: darwin
Optional libraries:
  Archive::Zip                 1.37
  Compress::Zlib               2.06
  Digest::MD5                  2.52
  Digest::SHA                  5.84_02
  IO::Compress::Bzip2          2.060
  POSIX::strptime              0.13
  Unicode::LineBreak           2016.003
  IO::Compress::RawDeflate     2.060
  IO::Uncompress::RawInflate   2.060


On Windows you will get a different list.

I can't say about the other modules.

- Phil
Title: Re: Test coverage
Post by: obetz on July 10, 2019, 02:06:00 AM
the question is whether you think there should be automated tests in t/ for some of them.
Title: Re: Test coverage
Post by: Phil Harvey on July 10, 2019, 07:20:24 AM
No.

- Phil
Title: Re: Test coverage
Post by: obetz on July 10, 2019, 04:39:51 PM
o.k. then I will add tests with a Windows cmd file for the Strawberry Perl based package.